Enable using -sign in VMR scenarios #108908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure from multi-phase signing (which has been removed since wixpacks were added)
ViktorHofer
reviewed
Oct 15, 2024
Member
Author
|
Signing logs look good for the runtime official build. I'll merge this in so it can flow and catch up with dotnet/sdk#44207, which enables some signing builds in the VMR. |
Contributor
|
@jkoritzinsky is this error related: dotnet/sdk#44014 (comment)? |
Member
Author
|
That may be. I'll look into it |
Member
Author
|
That error should be fixed by #108990 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable signing using the Arcade signing infra in VMR scenarios. This does not move the dotnet-runtime-official pipeline to use the Arcade signing infra, similar to how #99432 did not enable
-publishin dotnet-runtime-official.This PR adds the
-signflag to the inner invocation when the outer invocation is invoked with the-signflag to ensure we go down the Arcade signing and publishing route as expected.Based on the work in #100004
Fixes #108605
Runtime official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2561356&view=results